Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version does not parse if it doesn't start with a number #708

Open
gdamore opened this issue Jul 9, 2020 · 4 comments
Open

Version does not parse if it doesn't start with a number #708

gdamore opened this issue Jul 9, 2020 · 4 comments

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jul 9, 2020

I would like document details to have something like this

= My Book Title
My Name
Third Edition, July 4, 2020

Unfortunately the "Third Edition" part is not recognized as a version.

asciidoctor prepends the word "version" if the version looks like numeric X.Y.Z -- maybe just if it starts with a digit I haven't really explored it thoroughly -- but it still parses Third Edition properly as the version.

@xcoulon xcoulon added this to the v0.5.0 milestone Jul 9, 2020
@xcoulon
Copy link
Member

xcoulon commented Jul 9, 2020

ok, thanks for reporting this issue @gdamore.
IIRC I only did some testing with figures/numbers, not words such as "Third Edition"

@gdamore
Copy link
Collaborator Author

gdamore commented Jul 11, 2020

Well, corrected I stand -- I did some more testing -- and it turns out asciidoctor does not handle non numbers here.

Personally I believe this is a limitation that is easily solved, and we can do better.

@gdamore
Copy link
Collaborator Author

gdamore commented Jul 11, 2020

Having said that, this is the documented behavior, so I want to kick out of this milestone pending discussion.

@gdamore gdamore modified the milestones: v0.5.0, backlog Jul 11, 2020
@xcoulon
Copy link
Member

xcoulon commented Jul 11, 2020

Having said that, this is the documented behavior, so I want to kick out of this milestone pending discussion.

ok, sounds good to me. Thanks for the extra investigation @gdamore!

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 29, 2020
Verifies that special characters are properly
handled in paragraphs and delimited blocks

Fixes bytesparadise#708

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 29, 2020
Verifies that special characters are properly
handled in paragraphs and delimited blocks

Fixes bytesparadise#708

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants