Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support link macros in titles #956

Closed
DavidGamba opened this issue Feb 28, 2022 · 5 comments · Fixed by #999 or #1017
Closed

Support link macros in titles #956

DavidGamba opened this issue Feb 28, 2022 · 5 comments · Fixed by #999 or #1017
Assignees
@xcoulon
Labels
area/parser area/renderer type/feature
Milestone
v0.8.0

Comments

@DavidGamba
Copy link
Contributor

DavidGamba commented Feb 28, 2022 •
edited
Loading

For example:

.link in title https://github.com[Github]
----
content
----

Currently rendered as:

image
@xcoulon xcoulon added this to the v0.8.0 milestone Mar 3, 2022
@xcoulon xcoulon self-assigned this Apr 24, 2022
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Apr 30, 2022
@xcoulon
feat(parser): support link macros in titles
eb8b2f3 
Fixes bytesparadise#956

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@xcoulon xcoulon mentioned this issue Apr 30, 2022
Merged
xcoulon added a commit that referenced this issue Apr 30, 2022
@xcoulon
feat(parser): support link macros in titles (#999)
25ab040 
Fixes #956

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@DavidGamba
Copy link
Contributor Author

@xcoulon this is now rendering as:

link in title &{map[text:Github] 0xc000095ae0}

@xcoulon
Copy link
Member

xcoulon commented May 4, 2022

oh, my apologies, I forgot to check the rendering 🤦‍♂️
Let me fix that.

@xcoulon xcoulon reopened this May 4, 2022
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue May 5, 2022
@xcoulon
feat(renderer): support elements in titles
6a30ed4 
support elements such as links, etc.
follow-up of bytesparadise#999

Fixes bytesparadise#956

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@xcoulon xcoulon mentioned this issue May 5, 2022
Merged
xcoulon added a commit that referenced this issue May 5, 2022
@xcoulon
feat(renderer): support elements in titles (#1017)
e157d69 
support elements such as links, etc.
follow-up of #999

Fixes #956

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@xcoulon
Copy link
Member

xcoulon commented May 5, 2022

@DavidGamba it should work now 😅

@DavidGamba
Copy link
Contributor Author

DavidGamba commented May 5, 2022 •
edited
Loading

That did it, thanks so much!

@xcoulon
Copy link
Member

xcoulon commented May 5, 2022

well, thanks to you for opening the issue at first ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser area/renderer type/feature
Projects
None yet
Milestone
v0.8.0
2 participants
@xcoulon @DavidGamba