Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): remove usage of gover #1001

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Apr 30, 2022

Fixes #1000

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Fixes bytesparadise#1000

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #1001 (b70566d) into master (9f856f2) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   79.85%   80.09%   +0.23%     
==========================================
  Files          86       86              
  Lines        6796     6822      +26     
==========================================
+ Hits         5427     5464      +37     
+ Misses        869      859      -10     
+ Partials      500      499       -1     

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              23.3ms ± 3%    23.4ms ± 3%   ~     (p=0.579 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    67.6ms ± 2%    67.4ms ± 2%   ~     (p=0.604 n=9+10)
RealDocumentProcessing/mocking.adoc-2           66.6ms ± 1%    66.5ms ± 3%   ~     (p=0.829 n=8+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              8.86MB ± 0%    8.86MB ± 0%   ~     (p=0.529 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    24.1MB ± 0%    24.1MB ± 0%   ~     (p=0.604 n=10+9)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%   ~     (p=0.268 n=9+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                107k ± 0%      107k ± 0%   ~     (p=0.906 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      307k ± 0%      307k ± 0%   ~     (p=0.535 n=9+10)
RealDocumentProcessing/mocking.adoc-2             329k ± 0%      329k ± 0%   ~     (p=0.769 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              23.3ms ± 3%    24.6ms ± 9%  +5.60%  (p=0.007 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    67.6ms ± 2%    67.7ms ± 3%    ~     (p=0.780 n=9+10)
RealDocumentProcessing/mocking.adoc-2           66.6ms ± 1%    66.7ms ± 3%    ~     (p=0.460 n=8+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              8.86MB ± 0%    8.85MB ± 0%  -0.16%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    24.1MB ± 0%    24.0MB ± 0%  -0.29%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%  -0.59%  (p=0.000 n=9+8)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                107k ± 0%      106k ± 0%  -0.34%  (p=0.000 n=10+8)
RealDocumentProcessing/vertx-examples.adoc-2      307k ± 0%      305k ± 0%  -0.50%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2             329k ± 0%      326k ± 0%  -0.80%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 0329b9d into bytesparadise:master Apr 30, 2022
@xcoulon xcoulon deleted the Issue1000_coverage branch April 30, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing code coverage reports
1 participant