Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): simplify AttributeValueContent rules #1010

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 1, 2022

no need to parse 'Quote' at this stage (will be done later)

Signed-off-by: Xavier Coulon xcoulon@redhat.com

no need to parse 'Quote' at this stage (will be done later)

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1010 (a58fab0) into master (678e057) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          85       85           
  Lines        6860     6860           
=======================================
  Hits         5498     5498           
  Misses        856      856           
  Partials      506      506           

@github-actions
Copy link

github-actions bot commented May 1, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              20.5ms ± 4%    21.4ms ±13%   ~     (p=0.053 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    62.7ms ± 3%    64.6ms ± 6%   ~     (p=0.053 n=9+10)
RealDocumentProcessing/mocking.adoc-2           55.7ms ± 5%    55.8ms ± 8%   ~     (p=0.739 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.37MB ± 0%    9.37MB ± 0%   ~     (p=0.280 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.6MB ± 0%    26.6MB ± 0%   ~     (p=0.968 n=10+9)
RealDocumentProcessing/mocking.adoc-2           21.8MB ± 0%    21.8MB ± 0%   ~     (p=0.243 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                114k ± 0%      114k ± 0%   ~     (p=1.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      343k ± 0%      343k ± 0%   ~     (p=0.885 n=10+10)
RealDocumentProcessing/mocking.adoc-2             329k ± 0%      329k ± 0%   ~     (p=0.220 n=9+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              20.5ms ± 4%    18.8ms ± 3%   -8.18%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    62.7ms ± 3%    54.9ms ± 7%  -12.42%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           55.7ms ± 5%    53.0ms ± 6%   -4.85%  (p=0.001 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.37MB ± 0%    8.85MB ± 0%   -5.53%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.6MB ± 0%    24.0MB ± 0%   -9.86%  (p=0.000 n=10+9)
RealDocumentProcessing/mocking.adoc-2           21.8MB ± 0%    21.6MB ± 0%   -0.79%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                114k ± 0%      106k ± 0%   -6.36%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      343k ± 0%      305k ± 0%  -11.04%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             329k ± 0%      326k ± 0%   -0.90%  (p=0.000 n=9+10)

@xcoulon xcoulon merged commit 873c72b into bytesparadise:master May 1, 2022
@xcoulon xcoulon deleted the simplify_attribute_value_rules branch May 1, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant