Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): do not reparse image 'alt' attribute #1021

Merged
merged 1 commit into from
May 16, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 16, 2022

only apply attribute substitutions

Signed-off-by: Xavier Coulon xcoulon@redhat.com

only apply attribute substitutions

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1021 (13c98b7) into master (8c2d04a) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   79.99%   79.86%   -0.13%     
==========================================
  Files          85       85              
  Lines        7078     7078              
==========================================
- Hits         5662     5653       -9     
- Misses        891      901      +10     
+ Partials      525      524       -1     

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              18.0ms ± 1%    18.0ms ± 3%    ~     (p=0.161 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    53.4ms ± 1%    54.5ms ± 3%    ~     (p=0.095 n=10+9)
RealDocumentProcessing/mocking.adoc-2           48.5ms ± 1%    48.6ms ± 0%    ~     (p=0.165 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.35MB ± 0%    9.35MB ± 0%    ~     (p=0.481 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%  -0.00%  (p=0.006 n=9+9)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%  +0.00%  (p=0.006 n=8+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%    ~     (all equal)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%    ~     (p=0.092 n=7+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%    ~     (p=0.231 n=10+6)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              18.0ms ± 1%    16.8ms ± 2%   -6.97%  (p=0.000 n=9+7)
RealDocumentProcessing/vertx-examples.adoc-2    53.4ms ± 1%    45.9ms ± 5%  -14.04%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           48.5ms ± 1%    54.4ms ±33%     ~     (p=0.436 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.35MB ± 0%    8.85MB ± 0%   -5.40%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%   -7.91%  (p=0.000 n=9+9)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%   -0.52%  (p=0.000 n=8+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%   -6.15%  (p=0.000 n=8+7)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%   -8.17%  (p=0.000 n=7+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%   -0.53%  (p=0.000 n=10+8)

@xcoulon xcoulon merged commit 6f86cf4 into bytesparadise:master May 16, 2022
@xcoulon xcoulon deleted the image_alt_reparse branch May 16, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant