Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser/renderer): support Open Blocks without masquerading #1024

Merged
merged 1 commit into from
May 16, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 16, 2022

Fixes #1014

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Fixes bytesparadise#1014

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              18.3ms ± 1%    18.3ms ± 1%   ~     (p=0.931 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    53.8ms ± 1%    53.6ms ± 1%   ~     (p=0.105 n=10+10)
RealDocumentProcessing/mocking.adoc-2           48.8ms ± 1%    48.7ms ± 1%   ~     (p=0.842 n=10+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.33MB ± 0%    9.33MB ± 0%   ~     (p=0.739 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%   ~     (p=0.853 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%   ~     (p=0.604 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%   ~     (p=0.065 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%   ~     (p=0.092 n=7+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%   ~     (p=0.325 n=10+9)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              18.3ms ± 1%    17.0ms ± 0%   -7.21%  (p=0.000 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    53.8ms ± 1%    48.3ms ± 0%  -10.25%  (p=0.000 n=10+8)
RealDocumentProcessing/mocking.adoc-2           48.8ms ± 1%    47.5ms ± 0%   -2.58%  (p=0.000 n=10+8)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.33MB ± 0%    8.85MB ± 0%   -5.18%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%   -7.91%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%   -0.52%  (p=0.000 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%   -5.98%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%   -8.17%  (p=0.000 n=7+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%   -0.53%  (p=0.000 n=10+10)

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1024 (899f796) into master (efa738e) will increase coverage by 0.00%.
The diff coverage is 45.12%.

@@           Coverage Diff           @@
##           master    #1024   +/-   ##
=======================================
  Coverage   80.26%   80.27%           
=======================================
  Files          85       86    +1     
  Lines        6993     7016   +23     
=======================================
+ Hits         5613     5632   +19     
- Misses        860      862    +2     
- Partials      520      522    +2     

@xcoulon xcoulon merged commit ceef387 into bytesparadise:master May 16, 2022
@xcoulon xcoulon deleted the Issue1014_open_blocks branch May 16, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Open Blocks without masquerading
1 participant