Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): image alt without separators #1025

Merged
merged 1 commit into from
May 16, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 16, 2022

replace underscores and hyphens with spaces

Fixes #1019

Signed-off-by: Xavier Coulon xcoulon@redhat.com

replace underscores and hyphens with spaces

Fixes bytesparadise#1019

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              22.6ms ± 5%    23.0ms ± 8%    ~     (p=0.481 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    66.7ms ± 3%    66.9ms ± 5%    ~     (p=0.912 n=10+10)
RealDocumentProcessing/mocking.adoc-2           59.9ms ± 4%    59.7ms ± 4%    ~     (p=0.863 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    9.34MB ± 0%    ~     (p=0.684 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%  -0.00%  (p=0.046 n=9+8)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%    ~     (p=0.515 n=10+8)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%    ~     (p=0.721 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%  -0.00%  (p=0.032 n=10+6)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%    ~     (p=0.638 n=10+7)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              22.6ms ± 5%    20.8ms ± 3%   -7.91%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    66.7ms ± 3%    57.1ms ± 3%  -14.42%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           59.9ms ± 4%    57.7ms ± 2%   -3.59%  (p=0.001 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    8.85MB ± 0%   -5.21%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%   -7.92%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%   -0.52%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%   -6.02%  (p=0.000 n=10+8)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%   -8.18%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%   -0.54%  (p=0.000 n=10+10)

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1025 (5b2069d) into master (ceef387) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   80.27%   80.28%           
=======================================
  Files          86       86           
  Lines        7016     7019    +3     
=======================================
+ Hits         5632     5635    +3     
  Misses        862      862           
  Partials      522      522           

@xcoulon xcoulon merged commit c680ac4 into bytesparadise:master May 16, 2022
@xcoulon xcoulon deleted the Issue1019_image_alt branch May 16, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop character separators in image alt attribute
1 participant