Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): unexport 'opts' field in Context type #1029

Merged
merged 1 commit into from
May 21, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 21, 2022

finally addressing this long-time TODO comment ;)

Signed-off-by: Xavier Coulon xcoulon@redhat.com

finally addressing this long-time TODO comment ;)

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1029 (6ab7f30) into master (7bc20ec) will increase coverage by 0.00%.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##           master    #1029   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          86       86           
  Lines        7019     7020    +1     
=======================================
+ Hits         5635     5636    +1     
  Misses        862      862           
  Partials      522      522           

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              20.2ms ± 4%    20.7ms ± 4%    ~     (p=0.063 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    61.7ms ± 2%    59.3ms ± 2%  -3.92%  (p=0.000 n=10+8)
RealDocumentProcessing/mocking.adoc-2           56.6ms ± 3%    55.6ms ± 2%  -1.78%  (p=0.035 n=10+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    9.34MB ± 0%    ~     (p=0.699 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%  -0.01%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%    ~     (p=0.971 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%    ~     (p=0.312 n=10+7)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%    ~     (p=0.050 n=8+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%    ~     (p=1.000 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              20.2ms ± 4%    19.5ms ± 2%  -3.23%  (p=0.008 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    61.7ms ± 2%    57.3ms ± 3%  -7.04%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           56.6ms ± 3%    56.5ms ± 3%    ~     (p=0.739 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    8.85MB ± 0%  -5.22%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%  -7.92%  (p=0.000 n=10+8)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%  -0.53%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%  -6.02%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%  -8.18%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%  -0.54%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 2e7b5cb into bytesparadise:master May 21, 2022
@xcoulon xcoulon deleted the refactor_parser_context branch May 21, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant