Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(renderer): remove unused params in paragraph template #1030

Merged
merged 1 commit into from
May 21, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 21, 2022

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1030 (65749e1) into master (2e7b5cb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1030   +/-   ##
=======================================
  Coverage   80.28%   80.29%           
=======================================
  Files          86       86           
  Lines        7020     7013    -7     
=======================================
- Hits         5636     5631    -5     
+ Misses        862      861    -1     
+ Partials      522      521    -1     

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              17.9ms ± 1%    17.8ms ± 1%    ~     (p=0.236 n=8+9)
RealDocumentProcessing/vertx-examples.adoc-2    53.0ms ± 0%    53.6ms ± 1%  +1.10%  (p=0.001 n=8+10)
RealDocumentProcessing/mocking.adoc-2           51.0ms ± 6%    48.9ms ± 1%  -4.08%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    9.34MB ± 0%    ~     (p=0.543 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%    ~     (p=0.400 n=9+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%  +0.00%  (p=0.035 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%    ~     (p=0.370 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%    ~     (p=0.930 n=10+9)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%    ~     (p=0.120 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              17.9ms ± 1%    17.0ms ± 1%  -4.69%  (p=0.000 n=8+8)
RealDocumentProcessing/vertx-examples.adoc-2    53.0ms ± 0%    48.8ms ± 1%  -7.95%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           51.0ms ± 6%    48.7ms ± 3%  -4.54%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    8.85MB ± 0%  -5.22%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%  -7.91%  (p=0.000 n=9+9)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%  -0.57%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%  -6.01%  (p=0.000 n=10+7)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%  -8.18%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%  -0.56%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit d602a4a into bytesparadise:master May 21, 2022
@xcoulon xcoulon deleted the remove_unused_template_vars branch May 21, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant