Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(renderer): section numbering disabled and re-enabled #1040

Merged
merged 1 commit into from
Jun 11, 2022
Merged

fix(renderer): section numbering disabled and re-enabled #1040

merged 1 commit into from
Jun 11, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 11, 2022

also, moved logix to traverse the document in 'pkg/types'

Fixes #1039

Signed-off-by: Xavier Coulon xcoulon@redhat.com

@xcoulon
fix(renderer): section numbering disabled and re-enabled
627e0eb 
also, moved logix to traverse the document in 'pkg/types'

Fixes bytesparadise#1039

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.4ms ± 1%    25.4ms ± 1%   ~     (p=1.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    69.8ms ± 1%    69.7ms ± 1%   ~     (p=0.489 n=9+9)
RealDocumentProcessing/mocking.adoc-2           69.5ms ± 1%    70.3ms ± 2%   ~     (p=0.156 n=10+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%    10.6MB ± 0%   ~     (p=0.888 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    27.9MB ± 0%    27.9MB ± 0%   ~     (p=0.258 n=9+9)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    23.7MB ± 0%   ~     (p=0.156 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      123k ± 0%   ~     (p=0.795 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%   ~     (p=0.887 n=10+9)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      350k ± 0%   ~     (p=0.141 n=9+9)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.4ms ± 1%    16.9ms ± 4%  -33.30%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    69.8ms ± 1%    49.0ms ± 2%  -29.75%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           69.5ms ± 1%    48.6ms ± 3%  -30.01%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%     8.8MB ± 0%  -16.86%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.9MB ± 0%    24.0MB ± 0%  -13.95%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    21.6MB ± 0%   -8.89%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      106k ± 0%  -13.33%  (p=0.000 n=9+6)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.75%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      326k ± 0%   -6.69%  (p=0.000 n=9+7)

@xcoulon xcoulon merged commit b8e1fb4 into bytesparadise:master Jun 11, 2022
@xcoulon xcoulon deleted the Issue1039_sectnums branch June 11, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing section numbering when disabled and re-enabled
1 participant
@xcoulon