Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GHA caching built into actions/setup-node@v2 #271

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Jul 20, 2021

This was announced on GitHub's blog. Unfortunately, because our application code is in a subdirectory we can't use it quite yet.

At the moment, only lock files in the project root are supported.

So, this is a draft PR using the syntax described in the ADR, which will supposedly be implemented in the coming months.

@GaryGSC GaryGSC changed the title Use caching built into actions/setup-node@v2 Use caching built into actions/setup-node@v2 Jul 20, 2021
@github-actions
Copy link

github-actions bot commented Jul 20, 2021

Terraform Plan:

will create 1 resource:

  • local_file - appspec_json

will update 2 resources:

  • aws_s3_bucket - my_s3_bucket_logs
  • aws_lambda_function - test_lambda

will replace (delete then create) 1 resource:

  • aws_ecs_task_definition - task_def

see details

@GaryGSC GaryGSC added the blocked Something can't get done right now label Jul 20, 2021
@GaryGSC GaryGSC changed the title Use caching built into actions/setup-node@v2 Use GHA caching built into actions/setup-node@v2 Jul 20, 2021
@GaryGSC
Copy link
Member Author

GaryGSC commented Aug 9, 2021

It looks like this functionality has been released in v2.4.0.

@GaryGSC GaryGSC removed the blocked Something can't get done right now label Aug 9, 2021
@GaryGSC GaryGSC marked this pull request as ready for review August 9, 2021 16:04
@GaryGSC GaryGSC requested a review from a team August 9, 2021 16:06
@GaryGSC GaryGSC merged commit 6f19fbe into dev Aug 9, 2021
@GaryGSC GaryGSC deleted the setup-node-cache branch August 9, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants