Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document aws sso instead of awslogin #16

Merged
merged 2 commits into from
Sep 9, 2021
Merged

document aws sso instead of awslogin #16

merged 2 commits into from
Sep 9, 2021

Conversation

joshgubler
Copy link
Member

No description provided.

@joshgubler joshgubler requested a review from a team September 9, 2021 19:55
@joshgubler joshgubler self-assigned this Sep 9, 2021
GaryGSC
GaryGSC previously approved these changes Sep 9, 2021
View reviewed changes
mzroth
mzroth previously approved these changes Sep 9, 2021
View reviewed changes
@GaryGSC
Copy link
Member

GaryGSC commented Sep 9, 2021

Looks like CI is broken from the set-env change forever ago. This is just a docs change, though, so I'm fine with merging even without fixing CI.

@joshgubler joshgubler dismissed stale reviews from mzroth and GaryGSC via 1282808 September 9, 2021 19:56
@joshgubler joshgubler requested review from GaryGSC and mzroth September 9, 2021 19:57
GaryGSC
GaryGSC approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@GaryGSC GaryGSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joshgubler joshgubler merged commit 05f3d11 into master Sep 9, 2021
@joshgubler joshgubler deleted the sso branch September 9, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryGSC GaryGSC GaryGSC approved these changes

@mzroth mzroth Awaiting requested review from mzroth

Assignees

@joshgubler joshgubler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgubler @GaryGSC @mzroth