Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

remove ignore lifecycle owing to terraform aws provider fix #10

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

jvisker
Copy link

@jvisker jvisker commented Apr 3, 2020

@jvisker jvisker requested a review from a team April 3, 2020 20:35
Copy link
Contributor

@yoshutch yoshutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to change the example in the README to have the latest version

do we need to put in the README that this requires aws provider version 2.56 or greater?

@jvisker
Copy link
Author

jvisker commented Apr 3, 2020

@yoshutch I did change the readme example version. And I don't think we need to specify the required version in the documentation. We didn't do it before and I think terraform makes it fairly clear when you try to run commands that you need to do another init.

Copy link
Contributor

@yoshutch yoshutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 yes you did. my bad. lgtm

@jvisker
Copy link
Author

jvisker commented Apr 3, 2020

Also, I did test the changes. Now the termination wait time can actually be changed.

@jvisker jvisker merged commit 76edcbf into master Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants