bitread.py: fully parse type 1 and config packet length #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a
USR_ACCESS
value that starts with the same bit pattern as a type-2 packet (0b010[...]
) causesbitread.py
to generate an incorrect.bits
file and thus incorrect fault analysis data.The reason for this is that the check for the type-2 configuration packet is incorrectly triggered by this user-defined number.
To address this issue and tries to prevent incorrect type-2 packets from being parsed, this PR:
parse_config_packet()
and checks if this matches the length of the type-2 packet supplied in the bitstream.To reproduce using the original
bitread.py
, generate multiple variants of bitstreams of thebfat_demo_1
design using Vivado:Now, running the original
bitread.py
gives the following
.bits
files:Running the version of
bitread.py
from this PR gives: