Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise the code example #1640

Merged
merged 2 commits into from
Jan 11, 2022
Merged

revise the code example #1640

merged 2 commits into from
Jan 11, 2022

Conversation

ckeys
Copy link
Contributor

@ckeys ckeys commented Dec 27, 2021

What changes were proposed in this pull request?

  • Revise the code example in the script.

How was this patch tested?

  • Testing is done in the it file

Spark Core Compatibility

@ckeys ckeys force-pushed the discretizer_pengyi branch from 7aec9d4 to 1a08ab2 Compare December 28, 2021 03:38
@allwefantasy
Copy link
Contributor

  1. The function trainByGroup is not used so it should be removed.
  2. There are no predict example(register model as UDF and then run the test on example data)

@ckeys ckeys force-pushed the discretizer_pengyi branch 2 times, most recently from 63d7b88 to f66fe6b Compare December 30, 2021 08:39
allwefantasy and others added 2 commits January 4, 2022 10:24
@allwefantasy @ckeys
convert options in include statment to set statments (byzer-org#1633)
a5fc24e 
* convert options in include statment to set statments

* add test and fix exception throws when no suffix in  include statement

* ignore result check in pr_1633.mlsql

revise the code example

add checking multi group params

revise the remind msg when setting multi-group params in the Discretizer et

rename the checking functions
@ckeys
add register example for the discretizer et
1ed9a19
@ckeys ckeys force-pushed the discretizer_pengyi branch from f66fe6b to 1ed9a19 Compare January 4, 2022 02:33
@allwefantasy allwefantasy merged commit f1d9a02 into byzer-org:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellozepp hellozepp hellozepp approved these changes

@chncaesar chncaesar chncaesar approved these changes

@allwefantasy allwefantasy allwefantasy approved these changes

@lwz9103 lwz9103 Awaiting requested review from lwz9103

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ckeys @allwefantasy @chncaesar @hellozepp