Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasNextPage to Rest Datasource Paging Strategy #1704

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Conversation

allwefantasy
Copy link
Contributor

@allwefantasy allwefantasy commented Feb 26, 2022

What changes were proposed in this pull request?

  • Finshed changes describe

Add a new config in Rest Datasource: config.page.stop which to control when the page fetching should stop.

How was this patch tested?

  • Testing done
tech.mlsql.test.ds.MLSQLRestTest

Are there and DOC need to update?

  • Doc is finished

Spark Core Compatibility

@allwefantasy allwefantasy changed the title Add hasNextPage to Rest Datasource Paging Strategy Add hasNextPage to Rest Datasource Paging Strategy (Not ready yet) Feb 26, 2022
add hasNextPage to Page class

clean useless code in MLSQLRest

fix AutoIncrement/Offset page strategy hasNextPage issue

udpate

Solved in the console, when the page is empty, use the key combination option+space (mac) or control+space (Windows), an NPE error will occur.

Fixed the error of assert in AutoSuggestContext.scala

update

udpate

add some tests

update

update
@allwefantasy allwefantasy changed the title Add hasNextPage to Rest Datasource Paging Strategy (Not ready yet) Add hasNextPage to Rest Datasource Paging Strategy Feb 27, 2022
Copy link
Contributor

@chncaesar chncaesar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants