Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load/Train/Run 语法中的 where 条件参数默认被开启了 evaluateDynamicExpression 导致错误 #1760

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Load/Train/Run 语法中的 where 条件参数默认被开启了 evaluateDynamicExpression 导致错误 #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion streamingpro-core/src/main/java/streaming/dsl/mmlib/SQLAlg.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ trait SQLAlg extends Serializable {
def skipOriginalDFName: Boolean = true
def skipResultDFName: Boolean = true

def skipDynamicEvaluation: Boolean = false
def skipDynamicEvaluation: Boolean = true

def modelType: ModelType = UndefinedType

Expand Down
2 changes: 1 addition & 1 deletion streamingpro-core/src/main/java/tech/mlsql/dsl/adaptor/LoadAdaptor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class LoadProcessing(scriptSQLExecListener: ScriptSQLExecListener,
if (tempDS.isDefined ) {
// DataSource who is not MLSQLSourceConfig or if it's MLSQLSourceConfig then skipDynamicEvaluation is false
// should evaluate the v with dynamic expression
if (!tempDS.isInstanceOf[MLSQLSourceConfig] || !tempDS.asInstanceOf[MLSQLSourceConfig].skipDynamicEvaluation) {
if (tempDS.isInstanceOf[MLSQLSourceConfig] && !tempDS.asInstanceOf[MLSQLSourceConfig].skipDynamicEvaluation) {
option = _option.map { case (k, v) =>
val newV = Templates2.dynamicEvaluateExpression(v, ScriptSQLExec.context().execListener.env().toMap)
(k, newV)
Expand Down