Support callback header #1808
Merged
Support callback header #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
improve #1793 |
hellozepp
force-pushed
the
supportCallbackHeader1
branch
from
dad8bba to
f8bd7d7
Compare
添加callback header 添加callback header 添加callback header 添加callback header
hellozepp
force-pushed
the
supportCallbackHeader1
branch
from
f8bd7d7 to
514b8f5
Compare
fishcus
reviewed
Aug 8, 2022
|
|
||
| object RestUtils extends Logging with WowLog { | ||
| def httpClientPost(urlString: String, data: Map[String, String]): HttpResponse = { | ||
| def httpClientPost(urlString: String, data: Map[String, String], headers: Map[String, String]): HttpResponse = { |
fishcus
reviewed
Aug 8, 2022
| } catch { | ||
| case _: Exception => | ||
| logError(s"callbackHeader should be returned normally in the byzer callback!") | ||
| System.exit(1) |
fishcus
reviewed
Aug 8, 2022
| @@ -178,7 +187,8 @@ class RestController extends ApplicationController with WowLog with Logging { | |||
| RestUtils.httpClientPost(urlString, | |||
| Map("stat" -> s"""failed""", | |||
| "msg" -> (e.getMessage + "\n" + msgBuffer.mkString("\n")), | |||
| "jobInfo" -> JSONTool.toJsonStr(jobInfo))), | |||
| "jobInfo" -> JSONTool.toJsonStr(jobInfo)), | |||
| Map()), | |||
fishcus
reviewed
Aug 8, 2022
| val callbackHeaderString = param("callbackHeader") | ||
| var callbackHeader = Map[String,String]() | ||
| if (callbackHeaderString != null && callbackHeaderString.nonEmpty){ | ||
| callbackHeader = JsonUtils.fromJson[Map[String,String]](callbackHeaderString) |
There was a problem hiding this comment.
这里fromJson异常的情况是要block run/script的接口流程吗？ 还是要catch住，留个容错模式
There was a problem hiding this comment.
应该抛出，callbackHeader设置的不对会影响后续的callback
fishcus
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加callback header支持