#1832 fix load csv option encoding. #1833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root cause
加载csv文件时,为了完成skipNLines这个功能,文件被重新落盘一次。例如skipNLines=1,落盘的文件名就是
后续所有skipNLines=1的文件都将读取这个文件,而不是源文件。
在这个过程中,使用了
InputStreamReader
以及FSDataOutputStream
,他们会按照系统默认charset读取/写入文件。导致encoding失效。
dev design
对 encoding 进行特殊处理。
test evidence
测试了常见的文件编码
生成了如下的中间文件
文件的读取正常