Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

Support latest Go version #4

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Support latest Go version #4

merged 7 commits into from
Mar 19, 2020

Conversation

bzz
Copy link
Owner

@bzz bzz commented Mar 19, 2020

TODO

Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz
Copy link
Owner Author

bzz commented Mar 19, 2020

CI failure on tokenizer test has to do with how append works on regex matches, with are slices of bytes sharing the same array underneath, and is the exact cause of src-d#196

bzz added 4 commits March 19, 2020 17:46
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #4 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   67.66%   67.63%   -0.03%     
==========================================
  Files          22       22              
  Lines        1101     1100       -1     
==========================================
- Hits          745      744       -1     
  Misses        297      297              
  Partials       59       59              
Impacted Files Coverage Δ
internal/tokenizer/tokenize.go 97.50% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5e031...24874f6. Read the comment docs.

Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz bzz merged commit cc3ef62 into master Mar 19, 2020
@bzz bzz deleted the ci-newer-go branch March 19, 2020 18:00
bzz added a commit to go-enry/go-enry that referenced this pull request Mar 19, 2020
See bzz/enry#4 for details.

Test Plan:
 - go test ./...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants