Remove the unnecessary dependency on bytes
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmid
approved these changes
Sep 29, 2023
|
I can add an entry (I would add a new “NEXT RELEASE” entry for that, I suppose?). But, as it should be really transparent to users (removing dependencies is easy), would that be a notable change? |
|
If nothing else, I suppose it could be handy to keep track of which version dropped the dependency 🤷 |
`bytes` is provided by all the required OCaml versions, so drop it from the dependencies This makes it easy to compile QCheck (at least core) without a fully-working Opam environment
|
I added an changelog entry and rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, the
bytesdependency is really only useful to support older versions of OCaml (before 4.02), but QCheck requires at least 4.08 anyway.So this PR proposes to drop that dependency altogether.
To give this a bit more context, this PR comes from wanting to run some tests that use QCheck core in a CI setup where Opam is not an option (yet). So this is working by vendoring QCheck and relying on dune’s modularity. For some reason, dune resolves correctly the
unixlibrary required insrc/core/dunebut notbytes. With this PR, the dependencies of that CI setup drop to only OCaml and dune.