Fix infinite loop on impulse #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Property indicates whether or not the body has a shape, so give it a name that reflects that.
…ed when hasShape is false. _play or _pause being invoked when hasShape (previously called isLoaded) can lead to applyImpulse and __applyImpulse values getting messed up.
vincentfretin
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #24, together with some refactoring to improve code robustness in the future.
isLoadedproperty renamed tohasShapeto accurately reflect meaninghasShape(formerlyisLoaded) checks to inside_playand_pause. This ensures they are never invoked when the flags is not set (this was the original bug in Infinite loop when applying impulse to shape #24)I've verified all examples with the latest code, withh both 1.3.0 and 1.4.0. All run clean.
Some unit tests would be nice, but the existing UTs are so undeveloped that that's a big task for the future, rather than something I want to take on now.