Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Support dashes in user and repository name #13

Merged
merged 3 commits into from
Jul 1, 2020
Merged

[FIX] Support dashes in user and repository name #13

merged 3 commits into from
Jul 1, 2020

Conversation

gomorizsolt
Copy link
Collaborator

@gomorizsolt gomorizsolt commented Jul 1, 2020 •
edited by thisismydesign
Loading

The commentUrlRegex must support dashes since it's a totally valid character in the user/repo name.

Tested against this: https://api.github.com/repos/mbrn/material-table/issues/1592

@gomorizsolt gomorizsolt marked this pull request as ready for review July 1, 2020 11:51
thisismydesign
thisismydesign approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise looks good!

index.js Outdated Show resolved Hide resolved
@thisismydesign
Copy link
Member

After merge feel free to release. Make sure to bump a patch version and set v1 to follow the new release.

@gomorizsolt gomorizsolt merged commit 937f67b into master Jul 1, 2020
@gomorizsolt gomorizsolt deleted the fix-url-regex branch July 1, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisismydesign thisismydesign thisismydesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomorizsolt @thisismydesign