Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect release notifications #18

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Detect release notifications #18

merged 3 commits into from
Jul 20, 2020

Conversation

gomorizsolt
Copy link
Collaborator

@gomorizsolt gomorizsolt commented Jul 17, 2020 •
edited
Loading

@gomorizsolt gomorizsolt mentioned this pull request Jul 17, 2020
Closed
thisismydesign
thisismydesign requested changes Jul 17, 2020
View reviewed changes
Copy link
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the log adds value here, it's enough to simply resolve.

@gomorizsolt
Copy link
Collaborator Author

Thanks, makes sense.

@gomorizsolt gomorizsolt merged commit 1099e95 into master Jul 20, 2020
@gomorizsolt gomorizsolt deleted the detect-release-notifications branch July 20, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisismydesign thisismydesign thisismydesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomorizsolt @thisismydesign