Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API throttling #3

Closed
thisismydesign opened this issue Feb 7, 2020 · 5 comments
Closed

Add API throttling #3

thisismydesign opened this issue Feb 7, 2020 · 5 comments
Assignees

Comments

@thisismydesign
Copy link
Member

thisismydesign commented Feb 7, 2020

Although there're separate keys per repo and 5k available requests at a time, so hopefully a daily build will work just fine. Still, would be nice to at least get proper errors.

https://github.com/octokit/plugin-throttling.js/

actions/toolkit#106 and https://github.com/actions/toolkit/blob/fc9958ec6a57d1b08e9a387c49971faecd0f0405/packages/github/src/github.ts#L18 might be useful on how to use plugins.

@gomorizsolt
Copy link
Collaborator

AFAICT the prerequisite of this issue is #4 since there's no way to add plugins to @actions/github.

@gomorizsolt
Copy link
Collaborator

actions/toolkit#106 and https://github.com/actions/toolkit/blob/fc9958ec6a57d1b08e9a387c49971faecd0f0405/packages/github/src/github.ts#L18 might be useful on how to use plugins.

What's the purpose of these links? I mean it's straightforward how to use the throttle-plugin with #14(I've verified it locally, let's first merge/finish the active branches).

@thisismydesign
Copy link
Member Author

thisismydesign commented Mar 6, 2020

What's the purpose of these links? I mean it's straightforward how to use the throttle-plugin

I think I've found @octokit/action later and here I wasn't sure if/how we could use plugins. But you're right, now it should be straightforward.

@thisismydesign
Copy link
Member Author

Timebox 2h

@gomorizsolt
Copy link
Collaborator

Resolved by #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants