Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @octokit/action instead of @actions/github #14

Merged
merged 35 commits into from
Mar 5, 2020
Merged

Use @octokit/action instead of @actions/github #14

merged 35 commits into from
Mar 5, 2020

Conversation

gomorizsolt
Copy link
Collaborator

@gomorizsolt gomorizsolt commented Mar 4, 2020 •
edited
Loading

Issue #4.

@gomorizsolt
Replace async for-of loops with promises and forEach()
8be2c65
@gomorizsolt
Make sure Promise executions finish
52c56b2
@gomorizsolt
Remove push()
de6c928
@gomorizsolt
Add return statement before Promise.all() calls
2f03c96
@gomorizsolt
Log deleteArtifactsPromises
9a3a537
@gomorizsolt
Log artifactsRequestPromises
ce1173f
@gomorizsolt
Use octokit.paginate()
12d6c53
@gomorizsolt
Use octokit.paginate() correctly
fdc24a6
@gomorizsolt
Log artifacts
b49534e
@gomorizsolt
Move code around
a2a931b
@gomorizsolt
Fix flow
083f995
@gomorizsolt
Log deleted artifact's id
4a8333a
@gomorizsolt
Use object destruction, leave meaningful logs
b3eea07
@gomorizsolt
Remove then()
9a00a8d
@gomorizsolt
Log deleteArtifactPromises.length
0164477
@gomorizsolt
Remove unmeaningful console.log() statement
2c63673
@gomorizsolt
Remove .env from changes
593d558
@gomorizsolt
Remove catch() from Promise.all()
7aaf4c5
@gomorizsolt
Replace map() and filter() with reduce(), refactor
47cb03c
@gomorizsolt
Remove console.log() statements
fab7988
@gomorizsolt
Resolve merge conflicts
c1e0875
@gomorizsolt
Resolve merge conflicts
613c690
@gomorizsolt
Fix dev env
b9d2f17
@gomorizsolt
Remove async junk
56b3b4e
@gomorizsolt
Await Promise.all()
75d200b
@gomorizsolt
Improve namings, leave comment on missing normalization
7dcce22
@gomorizsolt
Moving code around
dec5abb
@gomorizsolt
Replace @actions/github with @octokit/action
46418fa
@gomorizsolt
Update .env.example, use Octokit from @octokit/action
442a101
@gomorizsolt
Remove token from getConfigs()
e577457
@gomorizsolt gomorizsolt mentioned this pull request Mar 4, 2020
Closed
@gomorizsolt gomorizsolt changed the base branch from master to issue-5-project-clean-up March 5, 2020 09:52
thisismydesign
thisismydesign approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion.

This could be merged before the other PRs, it could perhaps simplify them as well.

.env.example Outdated Show resolved Hide resolved
@gomorizsolt gomorizsolt changed the base branch from issue-5-project-clean-up to master March 5, 2020 10:17
@gomorizsolt gomorizsolt merged commit 767f21e into master Mar 5, 2020
@gomorizsolt gomorizsolt deleted the issue-4_use-octokit-action branch March 5, 2020 10:20
This was referenced Mar 5, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisismydesign thisismydesign thisismydesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomorizsolt @thisismydesign