Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Case when initialization process is stopped and the ads block whont work #30

Closed
jplot opened this issue Apr 12, 2020 · 1 comment · Fixed by #32
Closed

Case when initialization process is stopped and the ads block whont work #30

jplot opened this issue Apr 12, 2020 · 1 comment · Fixed by #32

Comments

@jplot
Copy link
Contributor

jplot commented Apr 12, 2020

Hello, I just noticed a probleme in the ads blocker.

When a error occure while fetching the URL lists, descibed bellow, the whole initialization process is stopped and the next lists are not fetched. The result is than all list are not loaded and the blocker not work as expected. Can you find what is the problem please ?

Thanks for your time,

dns                    | [INFO] plugin/ads: Initializing CoreDNS 'ads' plugin. Version 0.2.1
dns                    | [INFO] plugin/ads: Initializing CoreDNS 'ads' list update routines...
dns                    | [DEBUG] plugin/hosts: Parsed hosts file into 4 entries
dns                    | .:53
dns                    | CoreDNS-1.6.7
dns                    | linux/amd64, go1.13.8, da7f65b3-dirty
dns                    | [DEBUG] plugin/ads: Fetching list "https://hosts-file.net/psh.txt"...
dns                    | [ERROR] plugin/ads: Get https://hosts-file.net/psh.txt: net/http: TLS handshake timeout
dns                    | [INFO] plugin/ads: Initializing CoreDNS 'ads' plugin. Version 0.2.1
dns                    | [INFO] plugin/ads: Initializing CoreDNS 'ads' list update routines...
dns                    | [DEBUG] plugin/hosts: Parsed hosts file into 4 entries
dns                    | .:53
dns                    | CoreDNS-1.6.7
dns                    | linux/amd64, go1.13.8, da7f65b3-dirty
dns                    | [DEBUG] plugin/ads: Fetching list "https://hosts-file.net/psh.txt"...
dns                    | [ERROR] plugin/ads: Get https://hosts-file.net/psh.txt: dial tcp 3.234.198.254:443: i/o timeout
@c-mueller
Copy link
Owner

c-mueller commented Apr 12, 2020 via email

c-mueller added a commit that referenced this issue Apr 13, 2020
Fixes #30

Instead of crashing completely if a download URL is unavailable, like before, the plugin now continues loading the lists, skipping the failed list.
c-mueller added a commit that referenced this issue Apr 13, 2020
Fixes #30

Instead of crashing completely if a download URL is unavailable, like before, the plugin now continues loading the lists, skipping the failed list.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants