Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Adds 3 lists of malicious domains #25

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Adds 3 lists of malicious domains #25

merged 5 commits into from
Mar 11, 2020

Conversation

jplot
Copy link
Contributor

@jplot jplot commented Mar 6, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #25 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   60.98%   60.98%           
=======================================
  Files           8        8           
  Lines         510      510           
=======================================
  Hits          311      311           
  Misses        169      169           
  Partials       30       30

@c-mueller
Copy link
Owner

c-mueller commented Mar 6, 2020 •
edited
Loading

Note Please ignore this comment. Look at the next one!

Hey there,
thanks again for your submission. I personally don't think it's a great idea to fill up the default with too many lists, to make it highly restrictive, since the defaults can always be extended using the Corefile by the administrator.

However i am open for discussion to add these lists into the strict default setup.

It would also be nice if you could add the lists to the docs/lists.md document.

@c-mueller
Copy link
Owner

Oopsie from me here. I have overseen the fact that you have already added these lists to the strict setting in the first place. Sorry for that.

However could you please add the lists to the docs/lists.md document? Then i will approve this PR.

@c-mueller
Copy link
Owner

Looks good now. Thank you!

Sorry for the delay. Have been busy over the last few days.

@c-mueller c-mueller merged commit 290c388 into c-mueller:master Mar 11, 2020
c-mueller added a commit that referenced this pull request Mar 11, 2020
@c-mueller
Add Default whitelist to prevent blocking of some important Domains
319fd2c 
Resolves #25

- Replace URL of Kovabit list with the original
- Remove Zeustracker URL (has been Discontinued)
- Update Copyright headers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplot @c-mueller