Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests against slocum and seaglider netcdfs #24

Merged
merged 3 commits into from
Oct 27, 2021
Merged

added tests against slocum and seaglider netcdfs #24

merged 3 commits into from
Oct 27, 2021

Conversation

callumrollo
Copy link
Collaborator

First step to resolving Issue #19

These tests download previously created netcdfs from the slocum and seaexlorer examples, and check that both the data and metadata remain unchanged.

These tests should pass for refactoring. If intentional changes are made to the resultant netcdfs, we can update the examples we are testing against

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I guess we need to have the testdata in the repo though, rather than grabbing via url?

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving the comparison data to tests/results/ or some such. A separate repo isn't the end of the world, but how do we know what yo used to make the test data? This way we can see if the test data changes.

@callumrollo
Copy link
Collaborator Author

Cool, I'll add the test data into tests/results they're both < 1MB netcdfs. That will also make the test code simpler. If storing the versions becomes a space issue later we'll figure something out

@callumrollo callumrollo merged commit 579c59b into c-proof:main Oct 27, 2021
@callumrollo callumrollo deleted the callum-patch-7 branch November 9, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants