Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsis on left column links #413

Closed
cbeauchesne opened this issue Apr 2, 2019 · 5 comments
Closed

Ellipsis on left column links #413

cbeauchesne opened this issue Apr 2, 2019 · 5 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@cbeauchesne
Copy link
Member

Colonne gauche : si les titres sont longs, la fin en est cachée. Est-il possible de revenir à la ligne ? https://c2corg.github.io/c2c_ui/#/routes/1073751/fr/torrent-de-boussac

=> Fix must be discussed on forum, both solution has their pro/con

@cbeauchesne cbeauchesne added the need community approval This point must be debated and approved by c2c community label Apr 2, 2019
@brunobesson
Copy link
Member

What is the con on this case? There is no size problem caused by cards requiring same height or anything similar, oes it?

@cbeauchesne
Copy link
Member Author

Only one con : can take huge vertical place :

image

By the way, I think a small rework on V6 solution may be a good compromise :

image

@cbeauchesne
Copy link
Member Author

And other question : does elevation is really relevant here ?

@brunobesson
Copy link
Member

brunobesson commented Apr 3, 2019

can take huge vertical place

Using ellipsis instead of having multiple lnes won't really hcnage things (most titles will stay on one line, some on 2, and none more).

I think a small rework on V6 solution may be a good compromise

I approve this change

does elevation is really relevant here ?

Yes, I do think so.

@cbeauchesne
Copy link
Member Author

Ok, let's ship with that so.

@cbeauchesne cbeauchesne added good first issue Good for newcomers and removed need community approval This point must be debated and approved by c2c community labels Apr 3, 2019
cbeauchesne added a commit that referenced this issue Apr 15, 2019
On document views, display full title for associated waypoints #413
@cbeauchesne cbeauchesne added this to the 7.0.7 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants