Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad automatic change of main WP when we edit a route #775

Closed
fbunoz opened this issue Sep 6, 2019 · 0 comments
Closed

Bad automatic change of main WP when we edit a route #775

fbunoz opened this issue Sep 6, 2019 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@fbunoz
Copy link
Contributor

fbunoz commented Sep 6, 2019

Describe the bug
When we edit a route whose main WP is undefined, one of linked WP is set as main WP.
As it is allow to keep the main WP undefined (useful when it isn't necessary to put a WP name at the start of the title), if we don't be careful, we save this change.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.camptocamp.org/routes/49711/fr/tour-des-aiguilles-de-l-argentiere-col-de-la-croix-col-de-la-combe-madame-breche-du-pin
  2. Click on edit button
  3. Open Information section
  4. See that main WP is set with "Col de la Combe Madame"

Expected behavior
The good behaviour is to not change the main WP selection when we edit a route.
But when we create a route, it's useful to set automatically the main WP.

This bug exist since this enhancement has been developped : #759

@fbunoz fbunoz added the bug Something isn't working label Sep 6, 2019
@cbeauchesne cbeauchesne added the good first issue Good for newcomers label Sep 6, 2019
@cbeauchesne cbeauchesne self-assigned this Sep 19, 2019
cbeauchesne added a commit that referenced this issue Sep 25, 2019
Do not automaticly set main WP on edition #775
@cbeauchesne cbeauchesne added this to the 7.1.1 milestone Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants