Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simple FIT parser and link with Drag&Drop interaction #1732

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Implement simple FIT parser and link with Drag&Drop interaction #1732

merged 3 commits into from
Mar 17, 2021

Conversation

lbesson
Copy link
Member

@lbesson lbesson commented Mar 17, 2021

Solves #1724

@lbesson lbesson requested a review from brunobesson March 17, 2021 14:28
@asaunier
Copy link
Member

asaunier commented Mar 17, 2021 •
edited
Loading

\o/ 👍

@lbesson lbesson requested review from asaunier and cbeauchesne March 17, 2021 15:07
brunobesson
brunobesson reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@brunobesson brunobesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should handle fit files in file input too (and add missing kml)

src/js/fit/FIT.js Outdated Show resolved Hide resolved
src/js/fit/FIT.js Outdated Show resolved Hide resolved
src/js/fit/FIT.js Show resolved Hide resolved
@brunobesson
Copy link
Member

brunobesson commented Mar 17, 2021 •
edited
Loading

By the way, despite my small comments,

@brunobesson brunobesson mentioned this pull request Mar 17, 2021
Closed
@lbesson
Copy link
Member Author

lbesson commented Mar 17, 2021

there is an issue with the timestamps

@brunobesson
Copy link
Member

Please merge when you are ok, it's fine for me 👏

@lbesson lbesson merged commit 40abee5 into master Mar 17, 2021
@lbesson lbesson deleted the fit branch March 17, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobesson brunobesson brunobesson approved these changes

@asaunier asaunier Awaiting requested review from asaunier

@cbeauchesne cbeauchesne Awaiting requested review from cbeauchesne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbesson @asaunier @brunobesson