Fix for issue http://github.com/c3js/c3/issues/1691 #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an object has key that contains . or [], it is now correctly found
instead of searching for an inner object or array that does not exist.
Example:
var data = [{"key.withdot":"1"}]; // did not work before, works now
var data2 = [{"key":{"innerkey":"1"}}]; // still works
Updated test with new bugfix.
|
Any update on this issue? |
|
After I have run into the same problem again, could you please let this pass and release a new version? This would be a great new years present 👍 🥇 |
|
Would be great to include this bug fix into a main release as it is a big issue with any titles having dots (starting with domain names !!!) |
|
Is there an update on this issue? |
|
Can we merge this pr? |
|
When will this problem be solved ? |
Merged
|
closing in favor of #2761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bugfix for Fix for issue #1691
The bug was introduced with the implementation of #1471
See http://jsfiddle.net/L3obmfsn/ for a working example.
If an object has key that contains . or [], it is now correctly found
instead of searching for an inner object or array that does not exist.
Example:
var data = [{"key.withdot":"1"}]; // did not work before, works now
var data2 = [{"key":{"innerkey":"1"}}]; // still works
Updated test with new bugfix.