Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destroy function to prevent null error during Pie chart animation #2188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtange
Copy link

@vtange vtange commented Oct 4, 2017

addresses #2187
Modified .destroy function to not simply set $$.config and $$.data to null, as during a pie animation, these will quickly be checked as d3 animates things frame by frame. I set config back to the default, and data to an object with an empty targets array.

@codecov-io
Copy link

Codecov Report

Merging #2188 into master will decrease coverage by 0.1%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   73.88%   73.77%   -0.11%     
==========================================
  Files          51       51              
  Lines        4185     4191       +6     
==========================================
  Hits         3092     3092              
- Misses       1093     1099       +6
Impacted Files Coverage Δ
src/interaction.js 35.22% <0%> (ø) ⬆️
src/api.chart.js 10% <0%> (-2.5%) ⬇️
src/arc.js 69.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0391272...8ef424b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants