Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update updateSvgSize to be less fragile #2525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

beninsocrata
Copy link

I have been unable to find the culprit in our system, but something is killing the functionality that allows d3Selection.selectAll(<array>) on our platform. I have created a fork where I update the .selectAll to use the much more common form of a comma-separated string selector instead of the array of selectors

selection.selectAll doesn't support array syntax
Forgot to take out the array brackets in the first commit. The array version is fragile in our platform, so using the common comma separated string of selectors instead.
@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #2525 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2525   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files          54       54           
  Lines        4282     4282           
=======================================
  Hits         3449     3449           
  Misses        833      833
Impacted Files Coverage Δ
src/core.js 91.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feca844...9276ba0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants