Make sure innerRadius is not NaN value #2631
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: attribute dx: Expected length, "NaNpx". Replication: Happens every time lost focus from/to browser tab when gauge chart is dynamically generated. Investigation: w = config.gauge_width is has assigned value 10 $$.innerRadiusRatio is -Infinity $$.innerRadius is NaN
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
+ Coverage 80.15% 80.16% +<.01%
==========================================
Files 57 57
Lines 4516 4517 +1
==========================================
+ Hits 3620 3621 +1
Misses 896 896
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
+ Coverage 80.15% 80.16% +<.01%
==========================================
Files 57 57
Lines 4516 4517 +1
==========================================
+ Hits 3620 3621 +1
Misses 896 896
Continue to review full report at Codecov.
|
kt3k
reviewed
Jun 14, 2019
| @@ -492,7 +492,8 @@ ChartInternal.prototype.redrawArc = function (duration, durationForExit, withTra | |||
| backgroundArc | |||
| .exit() | |||
| .remove(); | |||
|
|
|||
|
|
|||
| $$.innerRadius = $$.innerRadius || 0; | |||
There was a problem hiding this comment.
I think this is not a right place to do this. How about checking this in updateRadius?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: attribute dx: Expected length, "NaNpx".
Replication:
Happens every time lost focus from/to browser tab when gauge chart is dynamically generated.
Investigation:
w = config.gauge_width is has assigned value 10
$$.innerRadiusRatio is -Infinity
$$.innerRadius is NaN