Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set shape-rendering for standard graph type #2691

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

panthony
Copy link
Contributor

The "shape-rendering" was introduced with the stanford graph type but it makes the scatter appears really .... not sharp.

This PR make it so that the crispEdges is only set for stanford.

Closes #2689

@codecov-io
Copy link

Codecov Report

Merging #2691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2691   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb80e7...da4978a. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #2691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2691   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb80e7...da4978a. Read the comment docs.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter's points appears "pixelated"
3 participants