Handles exception thrown by Firefox when calling getBBox within hidden element #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panthony
force-pushed
the
path/17-ff-bbox
branch
from
1d5a94c
to
a0999ae
Compare
kt3k
reviewed
Aug 25, 2019
| } catch (ignore) { | ||
| // Firefox will throw an exception if getBBox() is called whereas the | ||
| // element is rendered with display:none | ||
| // See https://github.com/c3js/c3/issues/2692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I made the change in #2672 I was not aware that Firefox threw an exception if the DOM element is not rendered (ex: display: none;).
This PR wraps every calls made to
getBBoxand returns an empty box instead.The method
getBoundingClientRectwas returning an object with all properties set to 0.Can't really add a test for this since this is FF specific and we only have a chrome runner
Closes #2692