Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to compile List with pointer to interface #1203

Closed
pherrymason opened this issue Jun 3, 2024 · 2 comments
Closed

Failing to compile List with pointer to interface #1203

pherrymason opened this issue Jun 3, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working Fixed Needs Verification Fixed, but needs verification that it works
Milestone

Comments

@pherrymason
Copy link

In version 0.5.5 this code is failing to compile:

module core::actions;
import std::collections::list;

interface Action {
    fn bool enter();
    fn bool update(float dt);
}

struct ActionList {
    char* name;
    List(<Action*>) actions;
}

With the error: FATAL ERROR Should be unreachable -> in sema_expr_analyse_type_access @ in /xxxxx/src/compiler/sema_expr.c:3116

Looks like the culprit is the List(<Action*>), as soon as I replace it with List(<int>) it compiles properly.

I'm on Mac aarch64.
Built c3c with llvm: stable 18.1.6

@lerno lerno self-assigned this Jun 3, 2024
@lerno lerno added the Bug Something isn't working label Jun 3, 2024
@lerno lerno added this to the 0.6.0 milestone Jun 3, 2024
@lerno
Copy link
Collaborator

lerno commented Jun 3, 2024

I have fixed this in the dev branch.

@lerno lerno added the Fixed Needs Verification Fixed, but needs verification that it works label Jun 3, 2024
@pherrymason
Copy link
Author

Tested and working!
Thanks!

lerno added a commit that referenced this issue Jun 12, 2024
…p" and "remove" function now return Optionals. RingBuffer API rewritten. Allocator interface changed. Deprecated Allocator, DString and mem functions removed. "identity" functions are now constants for Matrix and Complex numbers. `@default` implementations for interfaces removed. `any*` => `any`, same for interfaces. Emit local/private globals as "private" in LLVM, following C "static". Updated enum syntax. Add support [rgba] properties in vectors. Improved checks of aliased "void". Subarray -> slice. Fix of llvm codegen enum check. Improved alignment handling. Add --output-dir #1155. Removed List/Object append. `GenericList` renamed `AnyList`. Remove unused "unwrap". Fixes to cond. Optimize output in dead branches. Better checking of operator methods. Disallow `any` from implementing dynamic methods. Check for operator mismatch. Remove unnecessary bitfield. Remove numbering in --list* commands Old style enum declaration for params/type, but now the type is optional. Add note on #1086. Allow making distinct types out of "void", "typeid", "anyfault" and faults. Remove system linker build options. "Try" expressions must be simple expressions. Add optimized build to Mac tests. Register int. `assert(false)` only allowed in unused branches or in tests. Compile time failed asserts is a compile time error. Remove current_block_is_target. Bug when assigning an optional from an optional. Remove unused emit_zstring. Simplify phi code. Remove unnecessary unreachable blocks and remove unnecessary current_block NULL assignments. Proper handling of '.' and Win32 '//server' paths. Add "no discard" to expression blocks with a return value. Detect "unsigned >= 0" as errors. Fix issue with distinct void as a member #1147. Improve callstack debug information #1184. Fix issue with absolute output-dir paths. Lambdas were not type checked thoroughly #1185. Fix compilation warning #1187. Request jump table using @jump for switches. Path normalization - fix possible null terminator out of bounds. Improved error messages on inlined macros.

Upgrade of mingw in CI. Fix problems using reflection on interface types #1203. Improved debug information on defer. $foreach doesn't create an implicit syntactic scope.
Error if `@if` depends on `@if`. Updated Linux stacktrace. Fix of default argument stacktrace. Allow linking libraries directly by file path. Improve inlining warning messages. Added `index_of_char_from`. Compiler crash using enum nameof from different module #1205. Removed unused fields in find_msvc. Use vswhere to find msvc. Update tests for LLVM 19
@lerno lerno closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fixed Needs Verification Fixed, but needs verification that it works
Projects
None yet
Development

No branches or pull requests

2 participants