Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a speech bubble loading icon for Conversation task #39

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

walkingtowork
Copy link
Collaborator

@walkingtowork walkingtowork commented Aug 7, 2024

  • Speech bubble with three animated dots as a loading icon for the Conversation output screen
  • Setup to add other task-specific loading icons in the future
  • Bug fix for Model Detail Page in storybook
  • Bug fix for Conversations onSubmit is not a function
Screen Shot 2024-08-07 at 9 17 57 PM

@walkingtowork walkingtowork changed the title [WIP] Created a speech bubble loading icon for Conversation task Created a speech bubble loading icon for Conversation task Aug 7, 2024
@@ -19,6 +19,8 @@ export default function TextConversationOutput(props) {
props.trial
);

console.log('TextConversationOutput props', props);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving these in for now to do a bit of debugging for Conversations on Staging, but will remove them shortly

@ShivanshShalabh
Copy link
Collaborator

Looks good Alex 👍

@walkingtowork walkingtowork merged commit 0b6e56e into develop Aug 7, 2024
1 check failed
@walkingtowork walkingtowork deleted the chore/conversation-loading-icon branch August 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants