Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Improved CSV Preview truncation, bugfixes #42

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Chore: Improved CSV Preview truncation, bugfixes #42

merged 4 commits into from
Aug 27, 2024

Conversation

walkingtowork
Copy link
Collaborator

@walkingtowork walkingtowork commented Aug 23, 2024 •
edited
Loading

  • Added truncated rows and columns for CsvPreview, each will only display if respective row/col is overflowing
  • Moved warning text to top of preview and increased size for easier visibility
  • Fixed various broken text-related Sample Inputs
Screen Shot 2024-08-23 at 3 47 42 PM

Pull Request Checklist

  • Base Repository changed to c3sr/mlmodelscope
  • Base changed from master to develop
  • Pull Request name accurately reflects the work contained within
  • Bulleted list of changes included in the Pull Request
  • Screenshots/gifs of visual changes, if necessary
  • Reviewed and approved by a peer
  • Squash and merge changes

@walkingtowork walkingtowork changed the title [WIP] Chore: final updates Chore: Improved CSV Preview truncation Aug 23, 2024
@walkingtowork walkingtowork changed the title Chore: Improved CSV Preview truncation Chore: Improved CSV Preview truncation, fixed broken text Sample Inputs Aug 23, 2024
@walkingtowork walkingtowork changed the title Chore: Improved CSV Preview truncation, fixed broken text Sample Inputs Chore: Improved CSV Preview truncation, bugfixes Aug 23, 2024
@walkingtowork walkingtowork merged commit b066fbf into develop Aug 27, 2024
1 check failed
@walkingtowork walkingtowork deleted the chore/final-updates branch August 27, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@walkingtowork