Fix UB introduced by copying detail::FormatListN objects. #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying a
detail::FormatListN
object, the m_formatterStore must also be copied, otherwise the pointer in the parentFormatList
class are possibly invalid.This addresses the segfault explained in #58. The issue arises when
makeFormatList
returns an object which holds a pointer to memory created for the temporary object on the stack.