Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Playwright tests that did not include several last minute changes #188

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Fix Playwright tests that did not include several last minute changes #188

merged 7 commits into from
Feb 19, 2025

Conversation

PascalinDe
Copy link
Member

@PascalinDe PascalinDe commented Feb 18, 2025 •
edited
Loading

Changes that were forgotten to include:

  • ballot API changed
  • build information was updated
  • unauthenticated users cannot access the election forms at all anymore
  • the userIDs are batched in the addVoters API

@PascalinDe PascalinDe requested review from ineiti and MeKHell February 18, 2025 16:23
@PascalinDe PascalinDe changed the base branch from main to student25spring_access_control February 18, 2025 16:23
@PascalinDe
Copy link
Member Author

@MeKHell to fix the build test you need to add the new lines from .env.example to your local .env and restart the frontend container 🙂

ineiti
ineiti approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MeKHell
MeKHell approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@MeKHell MeKHell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PascalinDe PascalinDe merged commit 6d16002 into student25spring_access_control Feb 19, 2025
4 of 5 checks passed
@PascalinDe PascalinDe deleted the fix-playwright branch February 19, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ineiti ineiti ineiti approved these changes

@MeKHell MeKHell MeKHell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalinDe @ineiti @MeKHell