Feature/typescript app template #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 26, 2018 21:23
- added tsx extension to file pattern - changed filtering of existing files to match against new regex that matches _app.js and _app.tsx and is also easily extendable
- included custom webpack.config.js to add ts-loader - added simple tsconfig - added _app.tsx
To allow .ts and .tsx files webpack.config.js must be updated with resolve.extensions parameter This will ensure, that .ts and .tsx extensions must not be explicitly added in relative imports
lkostrowski
approved these changes
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use x0 inside of my own typescript projects, but it kinda felt dirty to create a custom
_app.jsfile instead of using TypeScript all along.The changes i did to make this work are really basic.
The only problem i could see is, that the user must add
ts-loadervia a customwebpack.config.js. This is kind of contrary to the zero config approach of x0 but i think this is ok for such a quick win.What do you think of this approach?