-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: [rebalance] add price type #1541
Conversation
Welcome back! @narumiruna, This pull request may get 303 BBG. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 21.77% 21.73% -0.04%
==========================================
Files 606 607 +1
Lines 43940 44002 +62
==========================================
Hits 9566 9566
- Misses 33692 33754 +62
Partials 682 682
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
1686cd5
to
8f2d551
Compare
Re-estimated karma: this pull request may get 313 BBG |
"github.com/c9s/bbgo/pkg/fixedpoint" | ||
) | ||
|
||
type PriceType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implement unmarshalJSON on PriceType ? and maybe you can transform the original string into upper case string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Re-estimated karma: this pull request may get 370 BBG |
Hi @narumiruna, Well done! 385 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xfc1d28f63a8bfa3fe976313d217662edddf61d59590d1513cbcf5f8e23074ad6 Thank you for your contribution! |
No description provided.