Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [rebalance] add price type #1541

Merged
merged 2 commits into from
Feb 23, 2024
Merged

FEATURE: [rebalance] add price type #1541

merged 2 commits into from
Feb 23, 2024

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 303 BBG.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 21.73%. Comparing base (06c533f) to head (dae445a).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
- Coverage   21.77%   21.73%   -0.04%     
==========================================
  Files         606      607       +1     
  Lines       43940    44002      +62     
==========================================
  Hits         9566     9566              
- Misses      33692    33754      +62     
  Partials      682      682              
Files Coverage Δ
pkg/types/price_type.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c533f...dae445a. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 313 BBG

"github.com/c9s/bbgo/pkg/fixedpoint"
)

type PriceType string
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement unmarshalJSON on PriceType ? and maybe you can transform the original string into upper case string

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 370 BBG

@narumiruna narumiruna merged commit 9538a41 into main Feb 23, 2024
3 of 5 checks passed
@narumiruna narumiruna deleted the narumi/price-type branch February 23, 2024 12:32
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 385 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xfc1d28f63a8bfa3fe976313d217662edddf61d59590d1513cbcf5f8e23074ad6

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants