Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: move trading related utility functions to the tradingutil package #1547

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Feb 23, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 280 BBG.

@c9s c9s enabled auto-merge February 23, 2024 10:48
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 295 BBG

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 21.71%. Comparing base (945c442) to head (36e90cf).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
- Coverage   21.77%   21.71%   -0.06%     
==========================================
  Files         606      605       -1     
  Lines       43939    43938       -1     
==========================================
- Hits         9566     9543      -23     
- Misses      33691    33713      +22     
  Partials      682      682              
Files Coverage Δ
pkg/strategy/grid2/grid.go 80.53% <100.00%> (ø)
pkg/strategy/grid2/strategy.go 33.53% <60.00%> (ø)
pkg/util/tradingutil/trades.go 34.61% <0.00%> (-25.39%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945c442...36e90cf. Read the comment docs.

@c9s c9s merged commit b72a176 into main Feb 23, 2024
4 of 5 checks passed
@c9s c9s deleted the refactor/tradingutil branch February 23, 2024 11:25
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 305 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xb9e036ff4556772fe022bb81b778c41818131dad6c1655706e0c99c0bf9227ec

Thank you for your contribution!

@c9s c9s restored the refactor/tradingutil branch February 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants