FIX: [dca2] all the profit will use in the first order of the next round #1552
Conversation
|
Welcome back! @kbearXD, This pull request may get 217 BBG. |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
==========================================
+ Coverage 21.74% 21.76% +0.01%
==========================================
Files 608 608
Lines 44014 44020 +6
==========================================
+ Hits 9573 9579 +6
Misses 33759 33759
Partials 682 682
Continue to review full report in Codecov by Sentry.
|
|
Re-estimated karma: this pull request may get 250 BBG |
pkg/strategy/dca2/open_position.go
Outdated
| var quantity fixedpoint.Value | ||
| // all the profit will use in the first order | ||
| if i == 0 { | ||
| profit = market.TruncatePrice(profit) |
There was a problem hiding this comment.
why not truncate profit outside of the loop?
|
Re-estimated karma: this pull request may get 265 BBG |
c9s
changed the title
fix precision problem truncate profit first
kbearXD
force-pushed
the
kbearXD/dca2/quote-investment-modify
branch
from
6e3d377
to
9ac8bb9
Compare
|
Re-estimated karma: this pull request may get 270 BBG |
|
Hi @kbearXD, Well done! 275 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x48174597374e61ac915a68483c41230ec33ddeb2ac24dda4706f5fdd9a7745a0 Thank you for your contribution! |
No description provided.