Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [bitget] support market order on bitget unfilled order conversion #1561

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

bailantaotao
Copy link
Collaborator

2023/11/05 The market order will be executed immediately, so this check is used to handle corner cases.
2024/03/06 After placing a Market Order, we can retrieve it through the unfilledOrder API, so we still need to
handle the Market Order status.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 278 BBG.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 21.99%. Comparing base (ceb3091) to head (9144580).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   21.98%   21.99%   +0.01%     
==========================================
  Files         615      615              
  Lines       44374    44382       +8     
==========================================
+ Hits         9754     9764      +10     
+ Misses      33927    33925       -2     
  Partials      693      693              
Files Coverage Δ
pkg/exchange/bitget/exchange.go 44.21% <100.00%> (+0.82%) ⬆️
pkg/exchange/bitget/convert.go 93.49% <66.66%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb3091...9144580. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 295 BBG

@bailantaotao bailantaotao force-pushed the edwin/bitget/test-place-order branch from 6c08e9b to 9144580 Compare March 6, 2024 06:52
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 300 BBG

@bailantaotao bailantaotao merged commit 38a155d into main Mar 6, 2024
5 checks passed
@bailantaotao bailantaotao deleted the edwin/bitget/test-place-order branch March 6, 2024 07:05
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 305 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x1ab8bd75b13ce47766cb6195e2368b6a4e916f25327c53fd5293f7ab5cb5d5c4

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants