-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add ExchangePublic #1575
feature: add ExchangePublic #1575
Conversation
Welcome back! @zenixls2, This pull request may get 221 BBG. |
instead of using PublicExchange, we follow the naming convention of Exchange interfaces here to name this new interface as ExchangePublic (Exchange + adj) |
Re-estimated karma: this pull request may get 502 BBG |
2fb951b
to
ea61b76
Compare
Re-estimated karma: this pull request may get 505 BBG |
ea61b76
to
f1a4879
Compare
Re-estimated karma: this pull request may get 520 BBG |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
+ Coverage 22.28% 22.40% +0.12%
==========================================
Files 615 615
Lines 44416 44431 +15
==========================================
+ Hits 9896 9956 +60
+ Misses 33814 33763 -51
- Partials 706 712 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Re-estimated karma: this pull request may get 545 BBG |
Re-estimated karma: this pull request may get 572 BBG |
Re-estimated karma: this pull request may get 590 BBG |
Hi @zenixls2, Well done! 595 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xed1388f5d208f1ee9c7517f9b8a4dadd5dcbbd9c1395916d08b8b3dd6d4329af Thank you for your contribution! |
This is for exporting bbgo as a library when we want to use ExchangeMarketService + Minimal for a Exchange with only public api enabled (without api keys)
Right now if we pass in empty api key and passphrase, a public api only exchange instance will be created. We also need to reuse some of the utilities inside bbgo to avoid rebuilding the wheels.