Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ExchangePublic #1575

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

zenixls2
Copy link
Collaborator

This is for exporting bbgo as a library when we want to use ExchangeMarketService + Minimal for a Exchange with only public api enabled (without api keys)

Right now if we pass in empty api key and passphrase, a public api only exchange instance will be created. We also need to reuse some of the utilities inside bbgo to avoid rebuilding the wheels.

@bbgokarma-bot
Copy link

Welcome back! @zenixls2, This pull request may get 221 BBG.

@zenixls2 zenixls2 requested review from c9s and gx578007 March 12, 2024 03:15
@zenixls2
Copy link
Collaborator Author

instead of using PublicExchange, we follow the naming convention of Exchange interfaces here to name this new interface as ExchangePublic (Exchange + adj)

@zenixls2 zenixls2 requested a review from kbearXD as a code owner March 12, 2024 05:10
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 502 BBG

@zenixls2 zenixls2 force-pushed the feature/loose_interface_public_data branch from 2fb951b to ea61b76 Compare March 12, 2024 05:13
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 505 BBG

@zenixls2 zenixls2 force-pushed the feature/loose_interface_public_data branch from ea61b76 to f1a4879 Compare March 12, 2024 05:18
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 520 BBG

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 22.40%. Comparing base (c5dbd4b) to head (8268ac1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
+ Coverage   22.28%   22.40%   +0.12%     
==========================================
  Files         615      615              
  Lines       44416    44431      +15     
==========================================
+ Hits         9896     9956      +60     
+ Misses      33814    33763      -51     
- Partials      706      712       +6     
Files Coverage Δ
pkg/types/exchange.go 52.00% <ø> (+52.00%) ⬆️
pkg/cache/cache.go 45.54% <33.33%> (ø)
pkg/exchange/binance/exchange.go 6.03% <41.66%> (+4.36%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5dbd4b...8268ac1. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 545 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 572 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 590 BBG

@zenixls2 zenixls2 merged commit 2a7ca42 into c9s:main Mar 13, 2024
5 checks passed
@bbgokarma-bot
Copy link

Hi @zenixls2,

Well done! 595 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xed1388f5d208f1ee9c7517f9b8a4dadd5dcbbd9c1395916d08b8b3dd6d4329af

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants