consistent config param for all sub-commands #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @lanphan, This pull request may get 212 BBG. |
|
Re-estimated karma: this pull request may get 217 BBG |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1603 +/- ##
=======================================
Coverage 22.57% 22.57%
=======================================
Files 619 619
Lines 44832 44832
=======================================
Hits 10122 10122
Misses 33982 33982
Partials 728 728 Continue to review full report in Codecov by Sentry.
|
c9s
approved these changes
Mar 26, 2024
|
Hi @lanphan, Well done! 227 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x8c4c26e462ea1583d16f4debe4545ac43f826c15f134156712311e6ace5c6856 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is persistent flag "config" with default value in root command, we don't need to add it again in all sub commands.
Already checked and run "backtest", "run" subcommands and it works
Remaining sub-commands already follow this style